Generated code should reuse shared packages #15173
Comments
|
+1 for this, as I've encountered this issue in #14708 and similar changes multiple times in the past. |
sdirix
added a commit
to eclipsesource/theia
that referenced
this issue
Mar 13, 2025
Src-gen is executed in the environment controlled by adopters. In the generated code dependencies are imported. If these dependencies are not located where webpack expects them, the adopter will experience build errors. This is not a common case, but it does happen in practice. The generated code is made more robust by reusing the shared core dependencies where applicable. As it's common to declare '@theia/core' as a dependency within the adopter package, this more commonly results in a working build. Resolves eclipse-theia#15173 Contributed on behalf of STMicroelectronics
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Theia we generate code for Browser, Node and Electron. In the generated code we import third party dependencies like
inversify. In Theia we encourage users to use@theia/core/shared/inversifyin their code, so we should do the same for the generated code.This prevents issues in which an adopter project has a different package layput than Theia does. For example if
inversifyis not hoisted to the root ofnode_modulesof an adopter, their webpack build ofsrc-genwill fail as the generatedrequire('inversify')can't be resolved, while their@theia/core/shared/inversifyimports will resolve asinversifyis successfully nested in@theia/core.The text was updated successfully, but these errors were encountered: