Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty appRoot in web plugin host #13762

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Return empty appRoot in web plugin host #13762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c36698f
Return empty appRoot in web plugin host
msujew Jun 4, 2024
1bb2519
Update documentation
msujew Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/plugin-ext/src/hosted/browser/worker/worker-env-ext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,9 @@ export class WorkerEnvExtImpl extends EnvExtImpl {
super();
}

/**
* Throw error for app-root as there is no filesystem in worker context
*/
override get appRoot(): string {
throw new Error('There is no app root in worker context');
// The documentation indicates that this should be an empty string
return '';
}

get isNewAppInstall(): boolean {
Expand Down
3 changes: 3 additions & 0 deletions packages/plugin/src/theia.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7734,6 +7734,9 @@ export module '@theia/plugin' {

/**
* The application root folder from which the editor is running.
*
* *Note* that the value is the empty string when running in an
* environment that has no representation of an application root folder.
*/
export const appRoot: string;

Expand Down
Loading