basics to allow for hidden cells #14573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <[email protected]>
msujew
reviewed
Dec 3, 2024
packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds basic functionality that can be used by adopters to add logic for hidden cells. Lays the foundation for adding support for colapsing cell regions.
How to test
Hard to test since it does not really add anything new. Best way is probably to modify the
getVisibleCellsmethod in theNotebookModelto check that everything sitll works for the visible cellsFollow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers