Fix problems related with menu bar updates on focus change. #14959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#14002 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
msujew
approved these changes
Feb 18, 2025
Comment on lines
163
to
165
| export function isMenuElement(element: HTMLElement | null): boolean { | ||
| return !!element && element.className.includes('lm-Menu'); | ||
| } |
There was a problem hiding this comment.
Question: Is this required? It does not seem to be in use and also uses Lumino stuff.
There was a problem hiding this comment.
Good catch, I ported this commit from the lumino-PR.
Signed-off-by: Thomas Mäder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR introduces an event object describing changes to the menu registry more precisely. The code that manages the menu bar then only rebuilds itself when the change actually concerns the main menu bar. This prevents the menu bar from being replaced when the keyboard focus changes.
Fixes #14002
How to test
Make sure you set the "title bar style" setting to "custom" (This issue does not affect the native menus). Observe that the Sample menu appears dynamically and is correctly displayed and works. Make sure the scenario from the linked issue is fixed. Test electron and browser cases.
Follow-ups
This is a workaround that fixes the problem at hand. To attack the root problem, we would have to solve #14879
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers