Consider TerminalLinkProvider contributions recursively #15177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #15050 by considering the TerminalLinkProvider contributions also recursively (i.e., consider TerminalLinkProvider contributions bound in the root container).
For a thorough analysis of the issue see #15050 (comment)
How to test
See #15050 description.
In short:
ls -l
Without the fix, there is no link provided, with the fix, the link is there and clicking leads to the file being opened in an editor.
Notes:
terminal-link-provider
from the test results in a phosphor error (ReferenceError: navigator is not defined
). So I am not sure how to mock the UI dependencies correctly and I haven't found a similar example/test case in the code base...Review checklist
Reminder for reviewers