Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure NOTEBOOK_CELL_TYPE context key is set during initialization #15182

Merged

Conversation

lessmost
Copy link
Contributor

What it does

This PR ensures that the context keys NOTEBOOK_CELL_TYPE, NOTEBOOK_CELL_MARKDOWN_EDIT_MODE, and NOTEBOOK_CELL_EDITABLE are properly set when opening a new notebook.

This update addresses a bug where pressing cmd/ctrl+enter immediately after opening a new notebook file does not trigger the execute command but instead adds new lines. Below is a gif demonstrating the issue. Note that I was pressing cmd+enter keys.

cmd_enter

How to test

Open a new notebook editor and focus on the first cell. Press ctrl/cmd + enter, and you will notice that it does not execute the cell command.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@JonasHelming JonasHelming requested a review from jonah-iden March 13, 2025 22:43
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! works great

@jonah-iden
Copy link
Contributor

Out of legal reasons you need to sign the eclipse contributor agreement. Otherwise we are not able to merge this.
You can find more info here https://www.eclipse.org/legal/eca/faq/

@lessmost
Copy link
Contributor Author

Out of legal reasons you need to sign the eclipse contributor agreement. Otherwise we are not able to merge this. You can find more info here https://www.eclipse.org/legal/eca/faq/

Done. I have just registered an Eclipse account and signed the ECA form.

@jonah-iden
Copy link
Contributor

Thanks alot!

@jonah-iden jonah-iden merged commit 02f8f75 into eclipse-theia:master Mar 14, 2025
9 of 11 checks passed
@github-actions github-actions bot added this to the 1.60.0 milestone Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants