Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly configure built-ins in browserify #809

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Jul 27, 2022

Sorry, it seems that when I cleaned up the built.js script I wrongly assigned the list of builtins to the root configuration object of browserify. Silly mistake. Now everything should work correctly on the browsers.

fixes #785

The builtins were wrongly passed in the root configuration object. They
should be set in the `builtins` property.

Close eclipse-thingweb#785
Signed-off-by: reluc <[email protected]>
Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the update with the browser UI sample provided in #785 (comment) and it works fine now.

👍

@danielpeintner danielpeintner merged commit d1f34b8 into eclipse-thingweb:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing to properties fails in browser
2 participants