Correctly configure built-ins in browserify #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The builtins were wrongly passed in the root configuration object. They should be set in the `builtins` property. Close eclipse-thingweb#785 Signed-off-by: reluc <[email protected]>
danielpeintner
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
I checked the update with the browser UI sample provided in #785 (comment) and it works fine now.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, it seems that when I cleaned up the
built.jsscript I wrongly assigned the list of builtins to the root configuration object of browserify. Silly mistake. Now everything should work correctly on the browsers.fixes #785