Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fixes writing binary data to influxdb... #284

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

mangodan2003
Copy link
Contributor

@mangodan2003 mangodan2003 commented Nov 21, 2024

... as it was it was writing the error message produced trying to parse binary as utf-8

bug

Copy link

PR missing one of the required labels: {'new feature', 'dependencies', 'internal', 'documentation', 'enhancement', 'breaking-change', 'bug'}

@mangodan2003 mangodan2003 changed the title Fixes writing binary data to influxdb... bug: Fixes writing binary data to influxdb... Nov 21, 2024
@JEnoch JEnoch added the bug Something isn't working label Dec 5, 2024
@JEnoch
Copy link
Member

JEnoch commented Dec 5, 2024

Well spotted! Thanks for fixing it!
I'll merge as soon as my comment is addressed.

@gabrik
Copy link
Contributor

gabrik commented Dec 6, 2024

Thanks @mangodan2003 for your contribution, however in order to be able to merge this you need to sign the Eclipse Contribution Agreement: https://www.eclipse.org/legal/eca/

@mangodan2003
Copy link
Contributor Author

RE the ECA, I have signed this previously and having checked it says it is still valid, but I have re-submitted it anyway having updated the info slightly.

@gabrik
Copy link
Contributor

gabrik commented Dec 6, 2024

RE the ECA, I have signed this previously and having checked it says it is still valid, but I have re-submitted it anyway having updated the info slightly.

Seems that the email used to sign the commits does not match the one used to sing the ECA.
see: https://api.eclipse.org/git/eca/status/gh/eclipse-zenoh/zenoh-backend-influxdb/284

@mangodan2003
Copy link
Contributor Author

I had gotten the impression it went by the github username, I've updated my email address on the ECA site. hopefully that resolves it.

@gabrik
Copy link
Contributor

gabrik commented Dec 6, 2024

I re-triggered the validation, seems ok now

Copy link
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM now !

@JEnoch JEnoch merged commit 1095b3c into eclipse-zenoh:main Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants