added multicast scouting ttl option #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
requested changes
May 22, 2024
| @@ -637,6 +647,7 @@ impl Runtime { | |||
| // Must set to nonblocking according to the doc of tokio | |||
| // https://docs.rs/tokio/latest/tokio/net/struct.UdpSocket.html#notes | |||
| socket.set_nonblocking(true)?; | |||
| socket.set_multicast_ttl_v4(multicast_ttl)?; | |||
There was a problem hiding this comment.
Here we don't join any multicast group. Isn't this a no-op?
There was a problem hiding this comment.
If I understand multicast properly, only listening for multicast packets requires joining a multicast group, but sending packets only requires sending to the correct IP address, and this is the function used in the scout function here to create the socket that send out multicast packets, so if the TTL is not set on this socket, then all the scouting messages sent will still have a TTL of 1. I tried taking this line out and saw that packet TTL was still 1.
|
@jeremiah-wooten Thank you for the contribution :) Welcome to Eclipse Zenoh! |
Mallets
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the ability to change the ttl on the multicast scouting socket from the default of 1