Improve bytes #1174
Improve bytes #1174
Conversation
zenoh/src/api/bytes.rs
Outdated
| @@ -2345,75 +2925,54 @@ mod tests { | |||
| hm.insert(0, 0); | |||
| hm.insert(1, 1); | |||
| println!("Serialize:\t{:?}", hm); | |||
| let p = ZBytes::from_iter(hm.clone().drain()); | |||
| let p = ZBytes::from(hm.clone()); | |||
There was a problem hiding this comment.
I love it. It's easier to use and understandable now.
| } | ||
|
|
||
| // Tuple (a, b, c) | ||
| macro_rules! impl_tuple3 { |
There was a problem hiding this comment.
I guess the reason we use macro instead of inline here is type issue, right?
There was a problem hiding this comment.
Correct and trait recursiveness...
| } | ||
| } | ||
|
|
||
| // HashMap |
There was a problem hiding this comment.
Do you think we can provide something similar for Vec? Now we only support Vec<u8>
There was a problem hiding this comment.
Unfortunately not. Rust does not support serialization and Vec<u8> should have a special treatment compared to Vec<T> where ZSerde: Serialize<T>.
An iterator of T is serialized in this way:
- Serialize
Tas standalone - Write length of serialized
Tinto final buffer - Append serialized
T
This allows to iterate over the elements T because we know where the serialized T starts and end.
u8 is a special case of T where we do not want to prepend the serialized length but just copy everything.
But in order to treat it differently, we need specialization in Rust... which is not supported :(
|
@evshary could you please review this PR? |
HashMapcharEncodingforu8,u16,u32,u64,u128,i8,i16,i32,i64,i128,f32,f64