Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adminspace encodings #1182

Merged
merged 4 commits into from
Jun 25, 2024
Merged

fix: adminspace encodings #1182

merged 4 commits into from
Jun 25, 2024

Conversation

gabrik
Copy link
Contributor

@gabrik gabrik commented Jun 24, 2024

After the removal of Value the encoding of the Admin Space have been lost.

So for instance this:

{
        "key": "@/router/8f2aef5a89c14100b70184094f5bdea9/status/plugins/storage_manager/volumes/file-system-volume",
        "value": {"root":"/home/vscode/.zenoh/zenoh_backend_fs","version":"0.11.0-dev"},
        "encoding": "application/json",
        "time": null
    }

becomes this:

{
        "key": "@/router/8f2aef5a89c14100b70184094f5bdea9/status/plugins/storage_manager/volumes/file-system-volume",
        "value": "eyJyb290IjoiL2hvbWUvdnNjb2RlLy56ZW5vaC96ZW5vaF9iYWNrZW5kX2ZzIiwidmVyc2lvbiI6IjAuMTEuMC1kZXYifQ==",
        "encoding": "zenoh/bytes",
        "time": null
    }

This PR aims at solving this bug.

@gabrik gabrik added the bug Something isn't working label Jun 24, 2024
@gabrik gabrik changed the base branch from main to dev/1.0.0 June 24, 2024 15:47
@gabrik
Copy link
Contributor Author

gabrik commented Jun 24, 2024

There are still some Key that provide a base64 response:

  • @/router/<id>/status/<plugin>/__path__
  • @/router/<id>/linkstate/routers
  • @/router/<id>/metrics

still investigating why

@gabrik
Copy link
Contributor Author

gabrik commented Jun 25, 2024

So a z_get gets them correct, the REST API does not...

@gabrik
Copy link
Contributor Author

gabrik commented Jun 25, 2024

Updated the Encoding matching in the REST plugin.

@gabrik gabrik marked this pull request as ready for review June 25, 2024 07:52
@gabrik gabrik requested a review from Mallets June 25, 2024 07:52
Signed-off-by: Gabriele Baldoni <[email protected]>
@Mallets Mallets merged commit 8f94b08 into dev/1.0.0 Jun 25, 2024
20 of 21 checks passed
@Mallets Mallets deleted the fix/adminspace-encodings branch June 25, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants