Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deadline adoption for multi-fragment message #1510

Merged
merged 3 commits into from
Oct 10, 2024
Merged

deadline adoption for multi-fragment message #1510

merged 3 commits into from
Oct 10, 2024

Conversation

yellowhatter
Copy link
Contributor

[closes #1494 ]

@yellowhatter yellowhatter added bug Something isn't working release Part of the next release internal Changes not included in the changelog labels Oct 4, 2024
@yellowhatter yellowhatter self-assigned this Oct 4, 2024
@yellowhatter yellowhatter marked this pull request as ready for review October 8, 2024 17:04
@yellowhatter
Copy link
Contributor Author

[closes #1494]

@yellowhatter
Copy link
Contributor Author

Briefly, improvements:

  • fix tests regression for multi-fragment message problem
  • fix perf regression for some platforms caused by too frequent time query
  • improve batching code readability (enum instead of cascaded options)

@yellowhatter yellowhatter removed the request for review from OlivierHecart October 10, 2024 11:10
@yellowhatter yellowhatter merged commit 7811f8e into eclipse-zenoh:main Oct 10, 2024
13 checks passed
@yellowhatter yellowhatter mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzypixelz fuzzypixelz fuzzypixelz approved these changes

Assignees

@yellowhatter yellowhatter

Labels
bug Something isn't working internal Changes not included in the changelog release Part of the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QoS: message fragments dropped
2 participants
@yellowhatter @fuzzypixelz