Fix GarbageCollect policy for corner cases #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mallets
reviewed
Jan 8, 2025
| return AltPolicy::alloc(layout, provider); | ||
| } | ||
| // try to alloc again only if GC managed to reclaim big enough chunk | ||
| if provider.garbage_collect() >= layout.size().get() { |
There was a problem hiding this comment.
This means that every allocation will trigger a garbage collection?
There was a problem hiding this comment.
Right, sorry. Updated
Mallets
approved these changes
Jan 8, 2025
YuanYuYuan
added a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Jan 9, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685)) --- Let me know if you'd like further refinements!
YuanYuYuan
added a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Jan 9, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))
YuanYuYuan
added a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Jan 9, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))
ahcorde
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Jan 10, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685))
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Jan 10, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685)) (cherry picked from commit 1f2d675)
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Jan 10, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685)) (cherry picked from commit 1f2d675)
ahcorde
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Jan 10, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685)) (cherry picked from commit 1f2d675) Co-authored-by: Yuyuan Yuan <[email protected]>
ahcorde
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Jan 10, 2025
This version includes the following fixes: - Fix memory leak in string deserialization ([zenoh-cpp#363](eclipse-zenoh/zenoh-cpp#363)) - Fix SHM Garbage Collection (GC) policy ([zenoh#1696](eclipse-zenoh/zenoh#1696)) - Fix deadlock in advanced subscription undeclaration ([zenoh#1685](eclipse-zenoh/zenoh#1685)) (cherry picked from commit 1f2d675) Co-authored-by: Yuyuan Yuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.