Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl Date/timestamp on update #203

Merged
merged 1 commit into from
Apr 2, 2024
Merged

feat: impl Date/timestamp on update #203

merged 1 commit into from
Apr 2, 2024

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Apr 2, 2024 •
edited by coderabbitai bot
Loading

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Summary by CodeRabbit

  • New Features
    • Introduced an autoUpdate property for DateTime and Timestamp columns to enable automatic updating of timestamps.
  • Documentation
    • Updated documentation to include details about the new autoUpdate property for time-related columns.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Apr 2, 2024 •
edited
Loading

Walkthrough

The recent update introduces an autoUpdate property for DateTimeParams and TimestampParams within the data access layer, enhancing control over automatic timestamp updates. This addition spans across the decorator definitions and runtime SQL generation logic, including test enhancements to ensure functionality. The modification aims to provide developers with more precise control over timestamp behaviors in database columns, streamlining data management and integrity.

Changes

File Path Change Summary
core/dal-decorator/src/decorator/Column.ts
plugin/dal/README.md		 Introduced autoUpdate property in DateTimeParams and TimestampParams.
core/dal-runtime/src/SqlGenerator.ts
core/dal-runtime/test/SqlGenerator.test.ts
core/dal-runtime/test/fixtures/modules/dal/AutoUpdateTime.ts		 Added handling and testing for TIMESTAMP columns with autoUpdate property, including SQL generation logic and test case addition.

🐰✨
In the realm of code where the data flows wide,
A tiny feature sprouts with pride.
Timestamps now gently sway,
Updating themselves, day by day.
Through fields of data, they now glide,
With autoUpdate by their side.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 2, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9fd585d and 58d2df8.
Files selected for processing (5)
  • core/dal-decorator/src/decorator/Column.ts (1 hunks)
  • core/dal-runtime/src/SqlGenerator.ts (1 hunks)
  • core/dal-runtime/test/SqlGenerator.test.ts (2 hunks)
  • core/dal-runtime/test/fixtures/modules/dal/AutoUpdateTime.ts (1 hunks)
  • plugin/dal/README.md (1 hunks)
Additional comments not posted (5)
core/dal-runtime/test/fixtures/modules/dal/AutoUpdateTime.ts (1)

1-51: LGTM! The AutoUpdateTime class is correctly defined with appropriate use of the autoUpdate property for date and timestamp columns.

core/dal-runtime/test/SqlGenerator.test.ts (1)

54-70: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [5-69]

LGTM! The new test case correctly verifies the SQL generation for the AutoUpdateTime table, ensuring the autoUpdate property is handled as expected.

core/dal-decorator/src/decorator/Column.ts (1)

87-93: LGTM! The addition of the autoUpdate property to both DateTimeParams and TimestampParams interfaces is correctly implemented, allowing for automatic updates of date and timestamp columns.

core/dal-runtime/src/SqlGenerator.ts (1)

129-143: LGTM! The changes to the SQL generation logic correctly handle TIMESTAMP columns with precision and the autoUpdate property, ensuring the automatic update feature is supported as expected.

plugin/dal/README.md (1)

358-369: LGTM! The documentation update correctly explains the autoUpdate property for DateTimeParams and TimestampParams, providing clear guidance on its usage.

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (9fd585d) to head (58d2df8).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   91.58%   91.86%   +0.28%     
==========================================
  Files         282      282              
  Lines        6561     6616      +55     
  Branches      951      980      +29     
==========================================
+ Hits         6009     6078      +69     
+ Misses        552      538      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@killagu killagu merged commit e5c7b8d into master Apr 2, 2024
13 checks passed
@killagu killagu deleted the feat/on_update branch April 2, 2024 13:18
@killagu
Copy link
Contributor Author

killagu commented Apr 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@killagu