Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning comparison of integer expressions of different signedness #802

Closed
fire opened this issue May 7, 2024 · 0 comments · Fixed by #833
Closed

Warning comparison of integer expressions of different signedness #802

fire opened this issue May 7, 2024 · 0 comments · Fixed by #833
Milestone

Comments

@fire
Copy link
Contributor

fire commented May 7, 2024

./thirdparty/manifold/src/manifold/include/manifold.h: In member function 'uint32_t manifold::MeshGL::NumVert() const':
Error: ./thirdparty/manifold/src/manifold/include/manifold.h:50:41: error: comparison of integer expressions of different signedness: 'std::vector<float>::size_type' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare]
   50 |     if (vertProperties.size() / numProp >= std::numeric_limits<int>::max())
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./thirdparty/manifold/src/manifold/include/manifold.h: In member function 'uint32_t manifold::MeshGL::NumTri() const':
Error: ./thirdparty/manifold/src/manifold/include/manifold.h:56:41: error: comparison of integer expressions of different signedness: 'std::vector<float>::size_type' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare]
   56 |     if (vertProperties.size() / numProp >= std::numeric_limits<int>::max())
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This was referenced Jun 8, 2024
@elalish elalish added this to the v3.0 milestone Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants