Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the zebra polygon #832

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Fix the zebra polygon #832

merged 4 commits into from
Jun 8, 2024

Conversation

elalish
Copy link
Owner

@elalish elalish commented Jun 5, 2024

Fixes #831, or at least it had better before we merge this. I removed a few holes and got it to triangulate properly, which gives us a few clues. The polygon appears to be valid. I haven't managed to make a minimized version yet though.

@elalish elalish self-assigned this Jun 5, 2024
@elalish
Copy link
Owner Author

elalish commented Jun 8, 2024

Nice work @kintel - this one horribly excellent polygon test revealed 4 different triangulator bugs. I still need to make the upside-down version work, but I'll save that for tomorrow. For now I want to bask in making this ridiculous zebra finally work.

@elalish
Copy link
Owner Author

elalish commented Jun 8, 2024

@pca006132 It seems our Windows CI got updated or something - suddenly it's very picky about possible data loss: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\include\xutility(5532,1): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [D:\a\manifold\manifold\build\src\manifold\manifold.vcxproj]
Do you know an easy way to get it to shut up?

@pca006132
Copy link
Collaborator

No idea, but should be easy to fix. Will do with #802.

@pca006132
Copy link
Collaborator

but the actual error seems to be

fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj

https://stackoverflow.com/questions/69903253/cmake-bigobj-no-such-file-or-directory

this may work:

if (MSVC)
  add_compile_options(/bigobj)
endif ()

@pca006132 pca006132 mentioned this pull request Jun 8, 2024
@pca006132
Copy link
Collaborator

btw I feel like the zebra.cpp file should be placed within another folder in the test directory, as I can foresee us adding more and more complicated test cases in the future.

@elalish
Copy link
Owner Author

elalish commented Jun 8, 2024

Perfect, that's exactly what I needed! Agreed about the separate test folder, but let's wait until we have another file in that category to create it.

@elalish elalish merged commit 12b9494 into master Jun 8, 2024
18 checks passed
@elalish elalish deleted the zebra branch June 8, 2024 20:00
This was referenced Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triangulation issue: Zebra
2 participants