-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the zebra polygon #832
Conversation
Nice work @kintel - this one horribly excellent polygon test revealed 4 different triangulator bugs. I still need to make the upside-down version work, but I'll save that for tomorrow. For now I want to bask in making this ridiculous zebra finally work. |
@pca006132 It seems our Windows CI got updated or something - suddenly it's very picky about possible data loss: |
No idea, but should be easy to fix. Will do with #802. |
but the actual error seems to be
https://stackoverflow.com/questions/69903253/cmake-bigobj-no-such-file-or-directory this may work: if (MSVC)
add_compile_options(/bigobj)
endif () |
btw I feel like the |
Perfect, that's exactly what I needed! Agreed about the separate test folder, but let's wait until we have another file in that category to create it. |
Fixes #831, or at least it had better before we merge this. I removed a few holes and got it to triangulate properly, which gives us a few clues. The polygon appears to be valid. I haven't managed to make a minimized version yet though.