Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifold alias #1049

Merged
merged 1 commit into from
Nov 16, 2024
Merged

manifold alias #1049

merged 1 commit into from
Nov 16, 2024

Conversation

pca006132
Copy link
Collaborator

For openscad/openscad#5308, basically let them link against manifold::manifold regardless if our library is installed or put in a subdirectory.

@pca006132
Copy link
Collaborator Author

@elalish this is the change I want to get into v3.0.

@pca006132 pca006132 mentioned this pull request Nov 16, 2024
@pca006132
Copy link
Collaborator Author

I guess I can go ahead and merge this? I verified this with openscad, so it should be fine. And this should be the last PR I want for v3.0

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, v3.0 here we come!

@elalish elalish merged commit 7de71d4 into master Nov 16, 2024
18 checks passed
@elalish elalish deleted the cmake-alias branch November 16, 2024 18:01
@elalish elalish mentioned this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants