Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix download-artifact #1062

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix download-artifact #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
with:
workflow: manifold.yml
workflow_conclusion: completed
branch: maser
# specific to the triggering workflow
run_id: ${{github.event.workflow_run.id}}
# do not download from old run
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
workflow: manifold.yml
workflow_conclusion: completed
branch: master
check_artifact: true
check_artifacts: true
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pca006132 any reason we should use branch: master here instead of run_id like above?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

publish_npm is not triggered by another workflow, so we can't do that.

name: wasm
path: ./bindings/wasm/

Expand Down
Loading