Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gltf-io and manifold-gltf #612

Merged
merged 17 commits into from
Nov 14, 2023
Merged

Improve gltf-io and manifold-gltf #612

merged 17 commits into from
Nov 14, 2023

Conversation

elalish
Copy link
Owner

@elalish elalish commented Nov 14, 2023

I had noticed some problems with https://manifoldcad.org/make-manifold, where objects with properties were sometimes losing them. It turns out I wasn't reading and writing attributes correctly sometimes, partly because of my gltf-io API.

Here I've:

  1. Transitioned gltf-io and manifold-gltf to TS (which caught several errors on its own)
  2. Changed the gltf-io API to use an id map and package each material with its attributes as Properties
  3. Applied usage groups to remove the gltf-transform warnings
  4. Fixed disposal and verified no unused or duplicate entries are being exported to the glTF
  5. Simplified the examples and verified that all glTFs now pass validation
  6. Added docs to gltf-io
  7. Improved Mesh declaration by adding MeshOptions interface.

Ideally I should look into publishing gltf-io and manifold-gltf to npm.

@elalish elalish self-assigned this Nov 14, 2023
@elalish elalish requested a review from pca006132 November 14, 2023 05:57
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7273c9b) 91.41% compared to head (5fe87b2) 91.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          35       35           
  Lines        4496     4496           
=======================================
  Hits         4110     4110           
  Misses        386      386           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132
Copy link
Collaborator

I am not very familiar with this, so I guess you can just merge it if it works :)

@elalish elalish merged commit 82b98d9 into master Nov 14, 2023
@elalish elalish deleted the gltf branch November 14, 2023 23:23
@elalish elalish mentioned this pull request Nov 17, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
* fixed build copy for npm

* update deps

* fixed glTF validator errors

* fixed bug and Vite

* clamped color

* converted manifold-gltf to TS

* converted gltf-io to TS

* fixed TS build

* avoid usage warnings

* update MV

* clean up types

* update gltf-io API

* fixed bugs

* fixed disposal

* fixed example

* a few fixes and cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants