Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove simplify from warp #677

Merged
merged 1 commit into from
Dec 28, 2023
Merged

remove simplify from warp #677

merged 1 commit into from
Dec 28, 2023

Conversation

elalish
Copy link
Owner

@elalish elalish commented Dec 28, 2023

Fixes #673

This simplification was added after someone found duplicate verts when warping a cylinder into a cone, but based on further discussion, it seems that does more harm than good. This PR also removes Simplify from SetProperties and CalculateCurvature - in those cases there was almost no chance it could simplify anything anyway. Now Simplify is only called by the Boolean ops, AsOriginal, and mesh import.

For now I'm not adding Simplify to the public API, mostly because I would rather have a better one that can collapse larger triangles accurately, rather than just removing degenerates like mine does. For now if you need Simplify you can call AsOriginal, or if you need to maintain IDs, you can create a new Manifold from GetMeshGL.

@elalish elalish self-assigned this Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c77a6a) 91.66% compared to head (8c8e804) 91.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
- Coverage   91.66%   91.65%   -0.01%     
==========================================
  Files          37       37              
  Lines        4737     4734       -3     
==========================================
- Hits         4342     4339       -3     
  Misses        395      395              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elalish elalish merged commit 30e0af9 into master Dec 28, 2023
@elalish elalish deleted the warpSimplify branch December 28, 2023 21:24
@elalish elalish mentioned this pull request Jan 7, 2024
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mesh simplification after warp is often undesirable
1 participant