Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #673
This simplification was added after someone found duplicate verts when warping a cylinder into a cone, but based on further discussion, it seems that does more harm than good. This PR also removes
Simplify
fromSetProperties
andCalculateCurvature
- in those cases there was almost no chance it could simplify anything anyway. NowSimplify
is only called by the Boolean ops,AsOriginal
, and mesh import.For now I'm not adding
Simplify
to the public API, mostly because I would rather have a better one that can collapse larger triangles accurately, rather than just removing degenerates like mine does. For now if you needSimplify
you can callAsOriginal
, or if you need to maintain IDs, you can create a new Manifold fromGetMeshGL
.