Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manifold_meshgl_merge to c bindings #820

Merged
merged 1 commit into from
May 23, 2024

Conversation

harmanpa
Copy link
Contributor

Add manifold_meshgl_merge to call MeshGL::Merge() on a duplicate mesh via the c bindings

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.22%. Comparing base (d437097) to head (d6f68bf).
Report is 26 commits behind head on master.

Files Patch % Lines
bindings/c/manifoldc.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
- Coverage   91.84%   89.22%   -2.62%     
==========================================
  Files          37       61      +24     
  Lines        4976     8444    +3468     
  Branches        0      928     +928     
==========================================
+ Hits         4570     7534    +2964     
- Misses        406      910     +504     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132
Copy link
Collaborator

Why do we need to duplicate the mesh here?

@harmanpa
Copy link
Contributor Author

Only because from_c returns a const so the compiler wouldn't allow it otherwise

@pca006132
Copy link
Collaborator

I see. LGTM.

@pca006132 pca006132 merged commit 8e2b1dd into elalish:master May 23, 2024
18 checks passed
@elalish elalish mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants