Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hull_test isMeshConvex() vertices check #898

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Aug 14, 2024

Don't know why this isn't failing on GitHub but for me Hull.FailingTest1 and Hull.FailingTest2 cause coredumps:

[ RUN      ] Hull.FailingTest1
manifold_test: /usr/include/glm/detail/type_vec3.inl:188: constexpr const T& glm::vec<3, T, Q>::operator[](length_type) const [with T = int; glm::qualifier Q = glm::packed_highp; length_type = int]: Assertion `(i) >= 0 && (i) < (this->length())' failed.

gdb:

#4  0x00007f3c1f970f26 in __assert_fail () from /usr/lib64/libc.so.6
#5  0x000056477e252666 in glm::vec<3, int, (glm::qualifier)0>::operator[] (this=<optimized out>, i=3)
    at /usr/include/glm/detail/type_vec3.inl:186
#6  glm::vec<3, int, (glm::qualifier)0>::operator[] (this=<optimized out>, i=3) at /usr/include/glm/detail/type_vec3.inl:186
#7  isMeshConvex (hullManifold=..., epsilon=epsilon@entry=8.9962799999999992e-06)
    at manifold-e26e01a2310db36c23240fb7ad2e9692f6411a92/test/hull_test.cpp:43
#8  0x000056477e252ba5 in Hull_FailingTest1_Test::TestBody (this=<optimized out>)
    at manifold-e26e01a2310db36c23240fb7ad2e9692f6411a92/test/hull_test.cpp:165

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! FYI @Kushal-Shah-03

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base (d437097) to head (2d866b8).
Report is 75 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   91.84%   87.26%   -4.58%     
==========================================
  Files          37       66      +29     
  Lines        4976     9442    +4466     
  Branches        0     1033    +1033     
==========================================
+ Hits         4570     8240    +3670     
- Misses        406     1202     +796     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kushal-Shah-03
Copy link
Contributor

Thanks for the catch, that might explain why some of the tests had a larger epsilon than expected, I had just assumed it was due to the conversion error. I will run my tests again.

@elalish elalish merged commit 952546b into elalish:master Aug 14, 2024
22 checks passed
@elalish elalish mentioned this pull request Nov 5, 2024
@cjmayo cjmayo deleted the hull_test branch November 8, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants