Fix test-{cmake,pkgconfig}.sh to create, not append, to test files. #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test.cpp file and the CMakeLists.txt/Makefile were created with the '>>' append in shell instead of '>'. Which means these files were growing on multiple invocations if *-consumer was not deleted between calls (which means that the test would fail the second time around). While at it, add the manifold/parallel.h include also to the pkg-config test. Make all includes 'system-header' style with angle brackets, as this is what users of the library would use.
hzeller
force-pushed
the
feature-20240910-fix-build-tests
branch
from
3d11914 to
76428e5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #919 +/- ##
==========================================
- Coverage 91.84% 88.40% -3.44%
==========================================
Files 37 62 +25
Lines 4976 8660 +3684
Branches 0 1059 +1059
==========================================
+ Hits 4570 7656 +3086
- Misses 406 1004 +598 ☔ View full report in Codecov by Sentry. |
pca006132
approved these changes
Sep 10, 2024
|
Nice catch. We were only running these in the CI/nix, so I was not aware that these were using appends. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test.cc file and the CMakeLists/Makefile were created with the '>>' append in shell instead of '>'. Which means these files were growing on multiple invocations if *-consumer was not deleted between calls (which means they would fail the second time around)
While at it, add the manifold/parallel.h include also to the pkg-config test.
Make all includes 'system-header' style with angle brackets, as this is what users of the library would use.