Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install manifold.pc under CMAKE_INSTALL_LIBDIR #946

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Sep 22, 2024

On platforms that install libmanifold under lib64, manifold.pc should be installed in the pkgconfig directory under lib64.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (d437097) to head (5bc74d5).
Report is 100 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
- Coverage   91.84%   88.25%   -3.59%     
==========================================
  Files          37       62      +25     
  Lines        4976     8668    +3692     
  Branches        0     1049    +1049     
==========================================
+ Hits         4570     7650    +3080     
- Misses        406     1018     +612     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132
Copy link
Collaborator

Btw did you find any other hardcoded paths in our other cmake files? Ideally those should be changed as well, if any.

@elalish elalish merged commit fa6a632 into elalish:master Sep 23, 2024
22 checks passed
@elalish elalish mentioned this pull request Nov 5, 2024
@cjmayo cjmayo deleted the pkgconfig-libdir branch November 8, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants