Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use span.type: external instead of span.type: ext #1225

Closed
roncohen opened this issue Jul 17, 2019 · 0 comments · Fixed by #1291
Closed

Use span.type: external instead of span.type: ext #1225

roncohen opened this issue Jul 17, 2019 · 0 comments · Fixed by #1291
Labels
breaking change

Comments

@roncohen
Copy link
Contributor

We should be using span.type: external instead of span.type: ext to align with the other agents in accordance with elastic/apm#117
@watson watson added this to the v3.0.0 milestone Aug 6, 2019
Qard added a commit to Qard/apm-agent-nodejs that referenced this issue Aug 15, 2019
@Qard
feat: use external as span type
d02ba00 
Rather than the shortened 'ext' use full 'external' in span types

Fixes elastic#1225
@Qard Qard mentioned this issue Aug 15, 2019
Merged
2 tasks
Qard added a commit to Qard/apm-agent-nodejs that referenced this issue Sep 18, 2019
@Qard
feat: use external as span type
8858f27 
Rather than the shortened 'ext' use full 'external' in span types

Fixes elastic#1225
Qard added a commit to Qard/apm-agent-nodejs that referenced this issue Sep 19, 2019
@Qard
feat: use external as span type
14265f2 
Rather than the shortened 'ext' use full 'external' in span types

Fixes elastic#1225
watson pushed a commit that referenced this issue Sep 20, 2019
@Qard @watson
feat: use external as span type (#1291)
7e7cade 
Rather than the shortened `ext` use full `external` in span types.

Fixes #1225 

BREAKING CHANGE: All `ext.*` span types have been renamed to
`external.*`.
@ogupte ogupte mentioned this issue Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use external as span type Qard/apm-agent-nodejs
4 participants
@roncohen @watson @graphaelli @Qard