Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split lifecycle-testing in component-test for cli and http #643

Merged
merged 4 commits into from
Mar 21, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 18, 2022

What

Split run_component_tests in two scripts:

  • run_component_tests_http
  • run_component_tests_cli

Then allow dynamic stages in the CI.

This framework uses env variables to pass from the CI to the Makefile and from the Makefile to the docker container, then the entrypoint.sh runs the given composer script.

Why

This approach will allow fine granularity and configuration without touching much the CI/packaging/makefile/dockerfiles

Therefore, it will also run faster since it runs less in more VMs

Test

component-test-cli -> see this-stage

component-test-http -> see this-stage

Kapture 2022-03-18 at 11 22 51

@apmmachine
Copy link
Contributor

apmmachine commented Mar 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-21T07:42:48.125+0000

  • Duration: 24 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 10732
Skipped 0
Total 10732

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v requested review from a team March 18, 2022 11:24
@v1v v1v self-assigned this Mar 18, 2022
@v1v v1v added automation Team:Automation Label for the Observability productivity team labels Mar 18, 2022
@v1v v1v marked this pull request as ready for review March 18, 2022 11:25
@v1v
Copy link
Member Author

v1v commented Mar 18, 2022

/test

Copy link
Contributor

@SergeyKleyman SergeyKleyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v1v, thank you very much :)

@v1v v1v merged commit 90ded8e into elastic:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-php automation Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants