[Elastic Log Driver] magefile cleanup, fix bug on plugin uninstall #16735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
needs_backport
|
run beats-ci/package |
jsoriano
approved these changes
Mar 3, 2020
fearful-symmetry
added
v7.7.0
and removed
needs_backport
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Mar 4, 2020
…lastic#16735) * clean up magefile, quality of life issues * remove commented out code * cleanup (cherry picked from commit d7d38f3)
fearful-symmetry
added a commit
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty short bugfix PR. There was an issue where the
Uninstallstep would fail if using a version other than8.0.0, as we were pulling the plugin name field from the wrong place. Also removes a vestigial option passed to the build step.