Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Saved Object name to Kibana audit logging #38307

Merged
merged 9 commits into from
Mar 19, 2024
Merged

Conversation

kc13greiner
Copy link
Contributor

@kc13greiner kc13greiner commented Mar 13, 2024

First PR in this repo!

This is my first change in this repo, please let me know if there is anything additional I should add/info missing

Thank you 😄 !

Proposed commit message

Kibana's Saved Object audit logs can now utilize a 'name' field

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes elastic/kibana#175626

Related to elastic/integrations#9318 and elastic/kibana#178350

Use cases

Consumers of the Kibana audit logging service will be able to add a name to Saved Object Audit events

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 13, 2024
Copy link
Contributor

mergify bot commented Mar 13, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kc13greiner? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 13, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 139 min 34 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kc13greiner kc13greiner added Filebeat Filebeat Team:Service-Integrations Label for the Service Integrations team labels Mar 13, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 13, 2024
@kc13greiner kc13greiner added the backport-skip Skip notification from the automated backport with mergify label Mar 13, 2024
@kc13greiner kc13greiner marked this pull request as ready for review March 14, 2024 17:37
@kc13greiner kc13greiner requested a review from a team as a code owner March 14, 2024 17:37
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kc13greiner

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024

@miltonhultgren miltonhultgren merged commit 51fb8b2 into main Mar 19, 2024
44 of 47 checks passed
@miltonhultgren miltonhultgren deleted the feature/add_so_name branch March 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Feature:Stack Monitoring Filebeat Filebeat Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kibana.saved_object.name to audit log schema
5 participants