Review feedback: corrected pointer comparison

elastic · Apr 11, 2024 · 749e878 · 749e878
1 parent 84a1faf
commit 749e878
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/pkg/controller/common/service_control.go b/pkg/controller/common/service_control.go
@@ -72,7 +72,7 @@ func needsRecreate(expected, reconciled *corev1.Service) bool {
 	}
 
 	// LoadBalancerClass is immutable once set if target type is load balancer
-	if expected.Spec.Type == corev1.ServiceTypeLoadBalancer && expected.Spec.LoadBalancerClass != reconciled.Spec.LoadBalancerClass {
+	if expected.Spec.Type == corev1.ServiceTypeLoadBalancer && !reflect.DeepEqual(expected.Spec.LoadBalancerClass, reconciled.Spec.LoadBalancerClass) {
 		return true
 	}
 

diff --git a/pkg/controller/common/service_control_test.go b/pkg/controller/common/service_control_test.go
@@ -247,6 +247,20 @@ func Test_needsRecreate(t *testing.T) {
 			},
 			want: false,
 		},
+		{
+			name: "No need to recreate if LoadBalancerClass has not changed",
+			args: args{
+				expected: corev1.Service{Spec: corev1.ServiceSpec{
+					Type:              corev1.ServiceTypeLoadBalancer,
+					LoadBalancerClass: ptr.To("my-customer/lb"),
+				}},
+				reconciled: corev1.Service{Spec: corev1.ServiceSpec{
+					Type:              corev1.ServiceTypeLoadBalancer,
+					LoadBalancerClass: ptr.To("my-customer/lb"),
+				}},
+			},
+			want: false,
+		},
 		{
 			name: "Needs recreate if LoadBalancerClass is changed",
 			args: args{