Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency docker.io/library/golang to v1.19.0 #5920

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 2, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
docker.io/library/golang final minor 1.18.5 -> 1.19.0
docker.io/library/golang stage minor 1.18.5 -> 1.19.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Aug 2, 2022
@thbkrkr
Copy link
Contributor

thbkrkr commented Aug 8, 2022

Jenkins test this please

@thbkrkr thbkrkr self-assigned this Aug 8, 2022
@thbkrkr
Copy link
Contributor

thbkrkr commented Aug 8, 2022

Let's continue to take the safest route as there is no rush and update golang after the first minor patch is released. Moreover, we can hope that golangci-lint will support go1.18 by then, which is still not the case today (golangci/golangci-lint#2649).

@thbkrkr thbkrkr closed this Aug 8, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Aug 8, 2022

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (1.19.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/docker.io-library-golang-1.x branch August 8, 2022 16:28
@barkbay
Copy link
Contributor

barkbay commented Aug 9, 2022

FWIW the K8S project migrated to 1.19 a few days ago, and I'm also using 1.19 on ECK for a few days without any problem.

Also this issue states that:

Since the version v1.45.0 golangci-lint supports go1.18.
But some linters don't work with generics, golangci-lint disable those linters automatically with go1.18.

@thbkrkr thbkrkr mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants