[Autoscaling] Add CPU recommender #5924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkbay
added
>enhancement
pebrc
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Nice work! 👍
In my testing, I think at least, I was not able to observe CPU based autoscaling but that might be due to the simulated load I was using that required more storage more than anything else.
One thing I noticed is that the ML autoscaling I had in place went a bit crazy and requested 9 ML nodes with 8 CPU each only to scale them down later (without me having created any ML models) I could not find a flaw in you implementation though and think this is purely due to the decision Elasticsearch made.
thbkrkr
approved these changes
Aug 11, 2022
pkg/controller/autoscaling/elasticsearch/autoscaler/recommender/cpu.go
Outdated
Show resolved
Hide resolved
pkg/controller/autoscaling/elasticsearch/autoscaler/recommender/cpu.go
Outdated
Show resolved
Hide resolved
pkg/controller/autoscaling/elasticsearch/autoscaler/recommender/cpu.go
Outdated
Show resolved
Hide resolved
pkg/controller/autoscaling/elasticsearch/autoscaler/recommender/cpu.go
Outdated
Show resolved
Hide resolved
pkg/controller/autoscaling/elasticsearch/autoscaler/recommender/cpu.go
Outdated
Show resolved
Hide resolved
...roller/autoscaling/elasticsearch/testdata/cpu-scaled-horizontally/elasticsearch-expected.yml
Show resolved
Hide resolved
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
This commit adds a CPU recommender to update the required Pods CPU according to the "processors" field in the Elasticsearch autoscaling capacity response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CPU recommender to the Autoscaling controller.
Fixes #5823