Update module sigs.k8s.io/controller-runtime to v0.13.0 #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
@elasticmachine run elasticsearch-ci/docs |
thbkrkr
force-pushed
the
renovate/sigs.k8s.io-controller-runtime-0.x
branch
from
ff19882 to
f246b23
Compare
|
@elasticmachine run elasticsearch-ci/docs |
thbkrkr
reviewed
Sep 9, 2022
| @@ -149,7 +149,7 @@ func TestReconcileAgent_Reconcile(t *testing.T) { | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: "testAgent-agent", | |||
| Namespace: "test", | |||
| Labels: addLabel(defaultLabels, hash.TemplateHashLabelName, "3369118503"), | |||
| Labels: addLabel(defaultLabels, hash.TemplateHashLabelName, "4210085657"), | |||
There was a problem hiding this comment.
I think it's because the controller-runtime upgrade also upgrades k8s from 0.24.4 to 0.25 where PodSpec has a new HostUsers *bool field. But it doesn't seem a good reason to change the value of the template hash as we don't use the new field? I think this is not the first time this happens but I will dig deeper this time.
There was a problem hiding this comment.
Nothing abnormal here, this is the normal behaviour of hash.HashObject and this is harmless. I verified and when the label of the Deployment is updated, Pods are left intact as their Spec didn't change.
|
elasticmachine run elasticsearch-ci/docs |
thbkrkr
approved these changes
Sep 12, 2022
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Thibault Richard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.12.3->v0.13.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.