-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update module go.elastic.co/apm/module/apmelasticsearch/v2 to v2.2.0 #6129
Update module go.elastic.co/apm/module/apmelasticsearch/v2 to v2.2.0 #6129
Conversation
note for context elastic/apm-agent-go#1274 and
|
@elasticmachine run elasticsearch-ci/docs |
This change has some undesirable consequences for our current monitoring cluster which runs 8.4.x not sure if the corresponding UI changes will in 8.5? Compare (top: old, bottom: new): IP instead of service name, the relevant information "Kubernetes API server" is somehow lost in the UI. I can try with 8.4 tomorrow or we upgrade our monitoring to 8.5 which might be a good idea anyway. |
I think I would keep the deprecated fields in use with a linter exception as long as the UI does not handle the new fields (does not seem to be the case in 8.5 yet) |
Revert changes to code for this deprecation.
@pebrc I've adjusted this to ignore the deprecation in this file, and reverted the code changes for now. |
@elasticmachine run elasticsearch-ci/docs |
@elasticmachine run elasticsearch-ci/docs (why did it not run yesterday, I wonder) |
This PR contains the following updates:
v2.1.0
->v2.2.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.