Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module go.elastic.co/apm/module/apmelasticsearch/v2 to v2.2.0 #6129

Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 1, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
go.elastic.co/apm/module/apmelasticsearch/v2 require minor v2.1.0 -> v2.2.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the >renovate PRs created by or relating to Renovate label Nov 1, 2022
@naemono
Copy link
Contributor

naemono commented Nov 2, 2022

note for context elastic/apm-agent-go#1274

and

21:38:34 [pkg/controller/common/tracing/apmclientgo/client.go:73 SA1019: span.Context.SetDestinationService is deprecated: use SetServiceTarget (staticcheck)
21:38:34 span.Context.SetDestinationService(apm.DestinationServiceSpanContext{

@naemono
Copy link
Contributor

naemono commented Nov 2, 2022

@elasticmachine run elasticsearch-ci/docs

@pebrc
Copy link
Collaborator

pebrc commented Nov 2, 2022

This change has some undesirable consequences for our current monitoring cluster which runs 8.4.x not sure if the corresponding UI changes will in 8.5?

Compare (top: old, bottom: new):

Screenshot 2022-11-02 at 19 24 42
Screenshot 2022-11-02 at 19 25 12

and (top: old, bottom: new)
Screenshot 2022-11-02 at 19 24 37
Screenshot 2022-11-02 at 19 25 24

IP instead of service name, the relevant information "Kubernetes API server" is somehow lost in the UI. I can try with 8.4 tomorrow or we upgrade our monitoring to 8.5 which might be a good idea anyway.

@pebrc
Copy link
Collaborator

pebrc commented Nov 7, 2022

I think I would keep the deprecated fields in use with a linter exception as long as the UI does not handle the new fields (does not seem to be the case in 8.5 yet)

@naemono
Copy link
Contributor

naemono commented Nov 7, 2022

@pebrc I've adjusted this to ignore the deprecation in this file, and reverted the code changes for now.

@thbkrkr
Copy link
Contributor

thbkrkr commented Nov 14, 2022

@elasticmachine run elasticsearch-ci/docs

@naemono
Copy link
Contributor

naemono commented Nov 15, 2022

@elasticmachine run elasticsearch-ci/docs

(why did it not run yesterday, I wonder)

@naemono naemono added the v2.6.0 label Nov 15, 2022
@naemono naemono merged commit a66a1d1 into main Nov 15, 2022
@naemono naemono deleted the renovate/go.elastic.co-apm-module-apmelasticsearch-v2-2.x branch November 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>renovate PRs created by or relating to Renovate v2.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants