Add additional Helm documentation for Fleet Server, and Agent #6154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing Elasticsearch/Kibana examples Move Fleet example to folder.
pebrc
reviewed
Nov 16, 2022
There was a problem hiding this comment.
LGTM but I would make the paths branch version specific. While testing this I realised that our Helm Chart release did not work properly. The Elastic Stack chart I get is still the one prior to the 2.5 release, without the Agent charts. We did not bump the Chart version of the stack chart when we added new dependencies which is a mistake, which I think we can only fix through a new release.
docs/orchestrating-elastic-stack-applications/stack-helm-chart.asciidoc
Outdated
Show resolved
Hide resolved
thbkrkr
reviewed
Dec 7, 2022
Co-authored-by: Thibault Richard <[email protected]>
Co-authored-by: Thibault Richard <[email protected]>
pebrc
approved these changes
Dec 12, 2022
|
I resolved the conflict with |
thbkrkr
reviewed
Dec 19, 2022
thbkrkr
reviewed
Dec 19, 2022
Make documentation more clear concerning xpack fleet namespace settings. Be consistent with namespace choice in readmes
thbkrkr
approved these changes
Dec 21, 2022
naemono
added a commit
to naemono/cloud-on-k8s
that referenced
this pull request
Dec 29, 2022
…c#6154) * Add additional helm documentation for Fleet Server, and Agent Add missing Elasticsearch/Kibana examples Move Fleet example to folder. * Make values links raw content, and using specific target tag. * Use current instead of master in links. Co-authored-by: Thibault Richard <[email protected]> * Use current in links. Co-authored-by: Thibault Richard <[email protected]> * Update all doc links to point to current, not master, or a branch. * Remove version from fleet example. Make documentation more clear concerning xpack fleet namespace settings. Be consistent with namespace choice in readmes * Remove additional version setting. Co-authored-by: Thibault Richard <[email protected]> Co-authored-by: Thibault Richard <[email protected]> (cherry picked from commit ea459ba) # Conflicts: # deploy/eck-stack/examples/agent/fleet-agents.yaml
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
naemono
added a commit
that referenced
this pull request
Jan 3, 2023
…#6263) * Add additional helm documentation for Fleet Server, and Agent Add missing Elasticsearch/Kibana examples Move Fleet example to folder. * Make values links raw content, and using specific target tag. * Use current instead of master in links. Co-authored-by: Thibault Richard <[email protected]> * Use current in links. Co-authored-by: Thibault Richard <[email protected]> * Update all doc links to point to current, not master, or a branch. * Remove version from fleet example. Make documentation more clear concerning xpack fleet namespace settings. Be consistent with namespace choice in readmes * Remove additional version setting. Co-authored-by: Thibault Richard <[email protected]> Co-authored-by: Thibault Richard <[email protected]> (cherry picked from commit ea459ba) # Conflicts: # deploy/eck-stack/examples/agent/fleet-agents.yaml
thbkrkr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional documentation for installing/managing Fleet Server, and managed Elastic Agents using the Helm charts.
While writing this, I noticed that the referenced examples in the documentation for Elasticsearch/Kibana were missing, and this also adds them where they need to be.