Add Selector to Logstash status #6854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While running some tests with the VerticalPodAutoscaler, I was unable to make it work with the Logstash CRD, which appears to be due to the lack of a selector in the LogstashStatus object. This commit adds the missing Selector.
barkbay
approved these changes
May 30, 2023
Co-authored-by: Michael Morello <[email protected]>
|
Thank you @barkbay! I am unable to merge into this repo, so I would appreciate if someone could do this for me once CI is green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running some tests with the VerticalPodAutoscaler, I was unable to make it work with the Logstash CRD, which appears to be due to the lack of a selector in the LogstashStatus object. This commit adds the missing Selector.