[CI] Update golangci linter step to avoid timeout

[uri-weisman]

Summary of your changes

Multiple builds are failing due to golangci linter timeout, instead of increasing the timeout let's try and add cache to the linter step, it might reduce the execution time.

• failed build example

Checklist

• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary README/documentation (if appropriate)

[mergify]

This pull request does not have a backport label. Could you fix it @uri-weisman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  NOTE: backport-skip has been added to this pull request.

[github-actions]

📊 Allure Report - 💚 No failures were reported.

Result	Count
🟥 Failed	0
🟩 Passed	33
⬜ Skipped	1

[orestisfl]

Doesn't this disable caching?

We might want to instead try running this job with the official instructions which claim that caching is enabled by default:

jobs:
  golangci:
    name: lint
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-go@v4
        with:
          go-version: '1.20'
          cache: false
      - name: golangci-lint
        uses: golangci/golangci-lint-action@v3
...

[uri-weisman]

I've added skip-pkg-cache to address a similar issue to this one.
I'll try your suggested setup as well, however, I'm still experimenting so I'll make it a draft pr.

[oren-zohar]

Seems like this would remove the caching, no?

[orestisfl]

Caching is supposed to be handled in https://github.com/golangci/golangci-lint-action

[uri-weisman]

Yeah, they mention it in the performance section:
https://github.com/golangci/golangci-lint-action#performance

According to the logs, it seems that cache is being used by the linter:
Restored cache for golangci-lint from key 'golangci-lint.cache-2790-1b6dbac67386be50dbf356cfb1597004c1acd945' in 53191ms

As evidence, the linter run was very fast (~32s) compared to the past.