Drop support for Python 3.5, add Black #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated the certificates to the most recent recommended ones because they have proper subjectAltName entries for |
sethmlarson
commented
Mar 25, 2020
| @@ -10,7 +10,7 @@ fi | |||
| set -euxo pipefail | |||
|
|
|||
|
|
|||
| TEST_SUITE=${TEST_SUITE-oss} | |||
| TEST_SUITE=${TEST_SUITE-xpack} | |||
There was a problem hiding this comment.
Switched to xpack by default because the test suite doesn't pass with oss due to ML.
sethmlarson
commented
Mar 25, 2020
|
|
||
| return partial_result, df | ||
|
|
||
| def _flatten_dict(self, y, field_mapping_cache): | ||
| out = OrderedDict() | ||
| out = {} |
There was a problem hiding this comment.
We don't need to use OrderedDict anymore because all Python dicts are ordered, free performance boost. :)
stevedodson
reviewed
Mar 26, 2020
stevedodson
added a commit
that referenced
this pull request
Mar 26, 2020
* Updating test matrix for 7.6 + removing oss for now. * Resolving 7.6.0 docs issues * Updating ML docs * Minor mod to support 6.x style indices. Currently, there is no specific test for this as it requires a 6.x cluster. 6.x is not officially supported by 7.x clients, but this is a friendly option for users. * Adding unittest for FieldMappings._extract_fields_from_mapping * Changing to f-string formatting and adding exception test * Reverting to OrderedDict Will change after #150 is merged.
|
All done with |
stevedodson
suggested changes
Mar 27, 2020
|
LGTM! |
RayDev1988
added a commit
to RayDev1988/Python_Elastic-
that referenced
this pull request
Mar 11, 2022
* Updating test matrix for 7.6 + removing oss for now. * Resolving 7.6.0 docs issues * Updating ML docs * Minor mod to support 6.x style indices. Currently, there is no specific test for this as it requires a 6.x cluster. 6.x is not officially supported by 7.x clients, but this is a friendly option for users. * Adding unittest for FieldMappings._extract_fields_from_mapping * Changing to f-string formatting and adding exception test * Reverting to OrderedDict Will change after elastic/eland#150 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for Python 3.5 and in the same branch adds Black+Flake8 and fixes all formatting issues. This PR is part of trying to get all Python clients on the same modern configuration for style and task management.
This PR consists of 4 commits, there are a lot of changes in the final commit so it's probably best to review each one individually:
pyupgradeto automatically do the upgrade from 3.5 -> 3.6: 9fbb21d