Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing var, std and flaky tests #185

Merged
merged 5 commits into from
Apr 15, 2020
Merged

Fixing var, std and flaky tests #185

merged 5 commits into from
Apr 15, 2020

Conversation

stevedodson
Copy link
Contributor

@stevedodson stevedodson commented Apr 15, 2020 •
edited by sethmlarson
Loading

Closes #182

@stevedodson
Copy link
Contributor Author

#182

@stevedodson stevedodson requested a review from sethmlarson April 15, 2020 15:23
sethmlarson
sethmlarson suggested changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI adding "Closes #(GH Issue Number)" will auto-link the issue to the PR and close the issue once the PR is merged. Pretty neat! I've edited this PR description for you.

Few comments for you.

sethmlarson
sethmlarson reviewed Apr 15, 2020
View reviewed changes
@stevedodson stevedodson requested a review from sethmlarson April 15, 2020 19:11
sethmlarson
sethmlarson approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have some work on refactoring locally that will merge with this too. :)

@sethmlarson sethmlarson merged commit 1bc83d1 into elastic:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix .var() to use Sample variance instead of Population
2 participants
@stevedodson @sethmlarson