Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pd.set_option display.max_rows None #308

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Add support for pd.set_option display.max_rows None #308

merged 3 commits into from
Nov 6, 2020

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Oct 28, 2020 •
edited
Loading

Closes #305

  • Added the support for both DataFrame and series
  • Added tests.
  • I also added **kwargs to our assert_test_* methods because check_less_precise is now deprecated, we have to use check_exact=False

@sethmlarson Please review 😄

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

sethmlarson
sethmlarson reviewed Nov 6, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment! :)

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8 V1NAY8 requested a review from sethmlarson November 6, 2020 16:16
sethmlarson
sethmlarson approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 6, 2020

Builds are good :)

@sethmlarson sethmlarson merged commit 789f895 into elastic:master Nov 6, 2020
@V1NAY8 V1NAY8 deleted the pd_set_option branch November 6, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for pd.set_option("display.max_rows", None)
3 participants
@V1NAY8 @elasticmachine @sethmlarson