Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to Pandas 1.3.0 and LightGBM 3.2.1 #362

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Add support to Pandas 1.3.0 and LightGBM 3.2.1 #362

merged 1 commit into from
Jul 27, 2021

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Jul 18, 2021 •
edited
Loading

Closes #248,#359

@sethmlarson / @stevedodson Please review :)

Ask jenkins to test this.

@elasticmachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

sethmlarson
sethmlarson suggested changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible we should support pandas 1.2.0 and 1.3.0. I left some suggestions on how we can do this. We should also test against both 1.2.0 and 1.3.0 if possible, might require some changes to our CI?

@V1NAY8 V1NAY8 requested a review from sethmlarson July 19, 2021 13:48
@sethmlarson
Copy link
Contributor

jenkins test this please

sethmlarson
sethmlarson reviewed Jul 19, 2021
View reviewed changes
sethmlarson
sethmlarson suggested changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Here's a few comments for you:

@sethmlarson
Copy link
Contributor

jenkins test this please

1 similar comment
@sethmlarson
Copy link
Contributor

jenkins test this please

sethmlarson
sethmlarson approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, only one change for you then I'll merge:

@sethmlarson
Copy link
Contributor

@V1NAY8 Can you rebase this on master?

@V1NAY8 V1NAY8 force-pushed the pandas_lightgbm branch from 523a2d8 to 6a5caef Compare July 26, 2021 16:34
@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Jul 26, 2021

Ok,
Rebase is done. Lets see what jenkins says
so some jupyter notebook tests will fail for 1.3.0, You want me to fix them in this PR itself ?

@sethmlarson
Copy link
Contributor

@V1NAY8 Yeah you can fix the notebook tests, thanks!

@sethmlarson
Copy link
Contributor

jenkins test this please

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Jul 27, 2021 •
edited
Loading

@sethmlarson Notebook tests are all good. All the tests are passed. Also Pandas doesnt support 3.6. Only that failed.
Is it okay to get merged ?

sethmlarson
sethmlarson approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethmlarson sethmlarson merged commit 193bcb7 into elastic:master Jul 27, 2021
@sethmlarson sethmlarson mentioned this pull request Jul 28, 2021
Closed
@V1NAY8 V1NAY8 deleted the pandas_lightgbm branch July 31, 2021 14:11
@sethmlarson sethmlarson mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify support of LightGBM v3
3 participants
@V1NAY8 @elasticmachine @sethmlarson