Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] make eland_import_hub_model an installable script #403

Merged
merged 3 commits into from
Oct 19, 2021
Merged

[ML] make eland_import_hub_model an installable script #403

merged 3 commits into from
Oct 19, 2021

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Oct 18, 2021 •
edited
Loading

This makes eland_import_hub_model an installable script.

@benwtrent benwtrent added the topic:NLP Issue or PR about NLP model support and eland_import_hub_model label Oct 18, 2021
sethmlarson
sethmlarson approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought on naming, otherwise this looks fine. We'll need to document this somewhere so users will know how to use this CLI.

sethmlarson
sethmlarson reviewed Oct 19, 2021
View reviewed changes
@benwtrent benwtrent changed the title [ML] make import-hub-model an installable script [ML] make eland_import_hub_model an installable script Oct 19, 2021
@sethmlarson sethmlarson merged commit d39c1cd into elastic:main Oct 19, 2021
@benwtrent benwtrent deleted the feature/ml-upload-script-refactor branch October 19, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
topic:NLP Issue or PR about NLP model support and eland_import_hub_model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benwtrent @sethmlarson