Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow reading Elasticsearch certs in Wolfi image" #734

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

pquentin
Copy link
Member

Reverts #732. Setting a different user actually breaks model upload, as Hugging Face writes to a cache folder unconditionally (even with caching disabled: https://huggingface.co/docs/datasets/v2.17.1/en/package_reference/main_classes#datasets.disable_caching). In my tests with --ca-certs I only checked that we could read the cert, unfortunately.

@pquentin pquentin requested a review from ezimuel October 11, 2024 12:19
Copy link
Contributor

@ezimuel ezimuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pquentin pquentin merged commit 1312e96 into main Oct 11, 2024
4 checks passed
@pquentin pquentin deleted the revert-732-fix-ca-cert-wolfi branch October 11, 2024 12:52
@pquentin pquentin self-assigned this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants