Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make headers case-insensitive #22623

Closed
mayyamus opened this issue Jan 14, 2017 · 3 comments
Closed

Make headers case-insensitive #22623

mayyamus opened this issue Jan 14, 2017 · 3 comments
Labels
>bug :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch help wanted adoptme

Comments

@mayyamus
Copy link

mayyamus commented Jan 14, 2017

Elasticsearch version:all

Plugins installed: []

JVM version:all

OS version:all

Description of the problem including expected versus actual behavior:
perhaps setHeaders method can't override default header in RestClient, because httpHeader names are case-insensitive.suggest converting all default header and request header names to lowercase/uppercase.

diff

@javanna javanna added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >bug labels Jan 16, 2017
@javanna javanna self-assigned this Jan 16, 2017
@javanna javanna removed their assignment Feb 28, 2017
@javanna javanna added the help wanted adoptme label Mar 22, 2018
@javanna javanna changed the title Perhaps setHeaders method can't override default header in RestClient Make headers case-insensitive Mar 22, 2018
@adityasrini
Copy link

I’d like to take this up if no one is already working on this or has been assigned to this.

@javanna
Copy link
Member

javanna commented Apr 5, 2018

go ahead @adityasrini thanks!

@javanna
Copy link
Member

javanna commented Jul 16, 2018

given that we have decided (see #30616) to remove support for default headers, as they are already supported by the apache http client which we use to perform requests, I am going to close this.

@javanna javanna closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch help wanted adoptme
Projects
None yet
Development

No branches or pull requests

3 participants