Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default headers overriding existing headers *FIX* #29554

Closed
wants to merge 1 commit into from
Closed

Default headers overriding existing headers *FIX* #29554

wants to merge 1 commit into from

Conversation

mP1
Copy link

@mP1 mP1 commented Apr 17, 2018

  • Have you signed the contributor license agreement?
    YES

  • Have you followed the contributor guidelines?
    YES

  • If submitting code, have you built your formula locally prior to submission with gradle check?
    YES

  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
    YES

  • If submitting code, have you checked that your submission is for an OS that we support?
    YES(osx)

  • If you are submitting this code for a class then read our policy for that.
    N/A

- RestClient
-- remove old Set tracking "added" headers.
-- use HttpHeaders.containsHeader instead.
-- Fixes #22623
@javanna
Copy link
Member

javanna commented Apr 17, 2018

hi @mP1 thanks for your PR. We already have a PR under review that fixes the same problem, see #29419. The user is addressing comments so we would prefer to integrate the existing PR. Your proposed solution is appealing, the problem here and in the other PR is though that they are both missing tests. I am closing this and I will reopen in case that other PR doesn't go anywhere.

@javanna javanna closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants