Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom tokenfilters in the _analyze endpoint cannot refer to other tokenfilters #32154

Closed
romseygeek opened this issue Jul 18, 2018 · 1 comment
Closed

Custom tokenfilters in the _analyze endpoint cannot refer to other tokenfilters #32154

romseygeek opened this issue Jul 18, 2018 · 1 comment
Assignees
@romseygeek
Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@romseygeek
Copy link
Contributor

The multiplexing tokenfilter and the (soon to be added) conditional tokenfilter both refer to other tokenfilters in their definitions. In the normal way of things, these are built by the AnalysisRegistry, but the _analyze endpoint allows the creation of custom tokenfilters without reference to an index, and this currently does not correctly handle these referring filters. This means that a multiplexer or conditional filter built against the _analyze endpoint will not apply any of their child filters to the tokenstream.
@romseygeek romseygeek added the :Search Relevance/Analysis How text is split into tokens label Jul 18, 2018
@romseygeek romseygeek self-assigned this Jul 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@romseygeek romseygeek mentioned this issue Jul 18, 2018
Merged
romseygeek added a commit that referenced this issue Jul 18, 2018
@romseygeek
Call setReferences() on custom referring tokenfilters in _analyze (#3…
cfb3014 
…2157)

When building custom tokenfilters without an index in the _analyze endpoint,
we need to ensure that referring filters are correctly built by calling
their #setReferences() method

Fixes #32154
romseygeek added a commit that referenced this issue Jul 18, 2018
@romseygeek
Call setReferences() on custom referring tokenfilters in _analyze (#3…
2d3c0db 
…2157)

When building custom tokenfilters without an index in the _analyze endpoint,
we need to ensure that referring filters are correctly built by calling
their #setReferences() method

Fixes #32154
@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romseygeek romseygeek

Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javanna @romseygeek @elasticmachine