Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date value type support for certain metrics in Rollup #34185

Closed
benwtrent opened this issue Oct 1, 2018 · 1 comment · Fixed by #34200
Closed

Add date value type support for certain metrics in Rollup #34185

benwtrent opened this issue Oct 1, 2018 · 1 comment · Fixed by #34200
Assignees
@benwtrent
Labels
:Analytics/Aggregations Aggregations >enhancement

Comments

@benwtrent
Copy link
Member

Currently, when creating a new RollupJobConfig only numeric field mapper types are supported for the different metrics.

Support for min, max and, value_count over date fields should be added. Since date can just be treated as a long, hopefully the change is not too pervasive.

This issue is blocking ML support for rollup indices: #31999

Pinging @colings86 @polyfractal
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Oct 1, 2018
@benwtrent
Rollup adding support for date field metrics (elastic#34185)
81add30
@benwtrent benwtrent mentioned this issue Oct 1, 2018
Merged
@benwtrent benwtrent self-assigned this Oct 3, 2018
benwtrent added a commit that referenced this issue Oct 16, 2018
@benwtrent
Rollup adding support for date field metrics (#34185) (#34200)
af2877c 
* Rollup adding support for date field metrics (#34185)

* Restricting supported metrics for `date` field rollup

* fixing expected error message for yaml test

* Addressing PR comments
benwtrent added a commit that referenced this issue Oct 16, 2018
@benwtrent
Rollup adding support for date field metrics (#34185) (#34200)
183282d 
* Rollup adding support for date field metrics (#34185)

* Restricting supported metrics for `date` field rollup

* fixing expected error message for yaml test

* Addressing PR comments
kcm pushed a commit that referenced this issue Oct 30, 2018
@benwtrent @kcm
Rollup adding support for date field metrics (#34185) (#34200)
6320608 
* Rollup adding support for date field metrics (#34185)

* Restricting supported metrics for `date` field rollup

* fixing expected error message for yaml test

* Addressing PR comments
@Mpdreamz Mpdreamz mentioned this issue Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benwtrent benwtrent

Labels
:Analytics/Aggregations Aggregations >enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rollup adding support for date field metrics (#34185) benwtrent/elasticsearch
2 participants
@benwtrent @elasticmachine