Implement deprecation info API for joda-java migration #42010
Labels
Comments
|
Pinging @elastic/es-core-infra |
pgomulka
added a commit
that referenced
this issue
May 29, 2019
Implement deprecation checks for joda-java.time incompatible patterns. The checks scan through indicies and pipelines looking for date fields in mappings and processors which might fail in 7.0 where java.time is used. relates #42010
pgomulka
added a commit
that referenced
this issue
Jun 5, 2019
Some clusters might have been already migrated to version 7 without being warned about the joda-java migration changes.
Deprecation api on that version will give them guidance on what patterns need to be changed.
relates. This change is using the same logic like in 6.8 that is: verifying the pattern is from the incompatible set ('y'-Y', 'C', 'Z' etc), not from predifined set, not prefixed with 8. AND was also created in 6.x. Mappings created in 7.x are considered migrated and should not generate warnings
There is no pipeline check (present on 6.8) as it is impossible to verify when the pipeline was created, and therefore to make sure the format is depracated or not
#42010
pgomulka
added a commit
that referenced
this issue
Jun 10, 2019
) Some clusters might have been already migrated to version 7 without being warned about the joda-java migration changes. Deprecation api on that version will give them guidance on what patterns need to be changed. relates. This change is using the same logic like in 6.8 that is: verifying the pattern is from the incompatible set ('y'-Y', 'C', 'Z' etc), not from predefined set, not prefixed with 8. AND was also created in 6.x. Mappings created in 7.x are considered migrated and should not generate warnings There is no pipeline check (present on 6.8) as it is impossible to verify when the pipeline was created, and therefore to make sure the format is deprecated or not backport#42659 closes #42010
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is currently no warning for joda-java pattern incompatibilities.
We should warn users who migrate from 6.x to 7 that their pattern might no longer work in 7 unless they update their mappings.
Pattern can be used in:
Incompatible pattern specifiers:
Y year-of-erain joda should be updated toy year-of-erain java.time.Ymeans week-based-year in java.timey yearin joda, should be updated tou yearin java.time. The difference between year and year-of-era is that year can have values<0for years before the era.xweek-yearin joda should be updated toYin java.time.x` means zone-offset in java.time.C centuryis no longer supported in java.timeZ time zone offset/idhas the same meaning in java.time as it had previously in joda. However it will fail when parsingZin a date. For instance2019-05-09T14:24:00.000Z(in Zulu/UTC time) will fail parsing.Xcould be used instead and correctly parse this date.z time zone text- Will printZfor Zulu given UTC timezone. Previously joda was printing UTC for utc timezone.The text was updated successfully, but these errors were encountered: