[Entitlements] Allow read access to a plugin's directory #124111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
auto-backport
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
reviewed
Mar 5, 2025
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/FileAccessTree.java
Outdated
Show resolved
Hide resolved
libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/FileAccessTree.java
Outdated
Show resolved
Hide resolved
.../entitlement/src/main/java/org/elasticsearch/entitlement/bootstrap/EntitlementBootstrap.java
Outdated
Show resolved
Hide resolved
rjernst
approved these changes
Mar 7, 2025
| return Paths.get(codeSource.getLocation().toURI()); | ||
| } catch (Exception e) { | ||
| // If we get a URISyntaxException, or any other Exception due to an invalid URI, we return null to safely skip this location | ||
| logger.info( |
💔 Backport failed
You can use sqren/backport to manually backport by running |
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Mar 7, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Mar 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 8, 2025
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Mar 9, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing checks for access to JAR files via URL, we realized that several libraries (our own XConent, Jackson, Tika) need to access the plugin's JARs for reflection purposes.
This PR adds a functionality to allow each plugin to read access on its own directory.