[POC] Ctrl clicking filters in Basic Table Actions #5124
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC - Don't merge
Duplicated description from discussion
Filter in/out
I'd like to take a moment to mention the repeated filter actions that we have in most DataGrid usages.
Applying two distinct filter buttons, one for in, one for out, within the cells themselves takes up a lot of room and adds a lot of noise for what I assume to be is a coupled action that can be simplified to a single experience.
What I mean is that the act of Filtering is a single action. It's whether they want to filter out or in that is the "choice". I would like to suggest a pattern/component that creates a unified experience around filtering at the data level. Primarily I mean, reducing the act to the primarily use "in" functionality, while prioritizing the "out" functionality.
I've POC'd a quick example of where I think we can optimize for "in" but still allow for quick "out" functionality, and then having both options be explicitly listed in the full format of the popover. The POC (I added to the Basic Table component because it was just easier) basically, creates a single "Filter" action that is shown on hover which when just clicked filters "In". But if the user
ctrl
clicks, will swap to an "out" function. Ten in the popover where we list ALL the options, the filter "in" and "out" are both explicitly listed.Here's a screenrecording:
Screen.Recording.2021-09-01.at.01.59.42.PM.mp4