Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Ctrl clicking filters in Basic Table Actions #5124

Closed
wants to merge 2 commits into from

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Sep 1, 2021

POC - Don't merge

Duplicated description from discussion

Filter in/out

I'd like to take a moment to mention the repeated filter actions that we have in most DataGrid usages.

Applying two distinct filter buttons, one for in, one for out, within the cells themselves takes up a lot of room and adds a lot of noise for what I assume to be is a coupled action that can be simplified to a single experience.

What I mean is that the act of Filtering is a single action. It's whether they want to filter out or in that is the "choice". I would like to suggest a pattern/component that creates a unified experience around filtering at the data level. Primarily I mean, reducing the act to the primarily use "in" functionality, while prioritizing the "out" functionality.

I've POC'd a quick example of where I think we can optimize for "in" but still allow for quick "out" functionality, and then having both options be explicitly listed in the full format of the popover. The POC (I added to the Basic Table component because it was just easier) basically, creates a single "Filter" action that is shown on hover which when just clicked filters "In". But if the user ctrl clicks, will swap to an "out" function. Ten in the popover where we list ALL the options, the filter "in" and "out" are both explicitly listed.

Here's a screenrecording:

Screen.Recording.2021-09-01.at.01.59.42.PM.mp4

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5124/

@cchaos cchaos closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants