-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20](backport #378) Bump npcap version to 1.79 #380
Conversation
(cherry picked from commit 43f2c42)
This backport is needed if |
Then do I also need the 1.20.13.x branch that I created from 1.20 and opened a backport PR into? 😕 |
Yes A bit of context, the We always support the last two Golang minor versions. If a change goes to Regarding For such, you need to get the golang version from https://github.com/elastic/beats/blob/main/.go-version or https://github.com/elastic/beats/blob/8.12/.go-version and then create the branch That's the only option to recreate the Unfortunately, when we built this ncap approach, we had to use docker images that were not publicly available, but the ncap release and golang release were not aligned... that's the reason for using Therefore, if ncap needs to be updated, then you will need:
|
This pull request has not been merged yet. Could you please review and merge it @andrewkroh? 🙏 |
1 similar comment
This pull request has not been merged yet. Could you please review and merge it @andrewkroh? 🙏 |
💚 Build Succeeded
History
cc @andrewkroh |
💚 Build Succeeded
History
cc @andrewkroh |
Needs review. |
💚 Build Succeeded
History
cc @andrewkroh |
@andrewkroh, you can review it and I guess the |
This is an automatic backport of pull request #378 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com